Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code quality doc to project #2241

Merged
merged 1 commit into from
Nov 10, 2022
Merged

add code quality doc to project #2241

merged 1 commit into from
Nov 10, 2022

Conversation

merobi-hub
Copy link
Collaborator

Signed-off-by: Michael Robinson merobi@gmail.com

Problem

That the project has a code quality assurance document is a requirement of the LFAI.

Solution

This will add such a document to the project.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #2241 (8a677f2) into main (2913809) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2241   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1147     1147           
=========================================
  Files           219      219           
  Lines          5318     5318           
  Branches        423      423           
=========================================
  Hits           4080     4080           
  Misses          763      763           
  Partials        475      475           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Michael Robinson <merobi@gmail.com>
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll! Thanks, @merobi-hub! 🥇

@wslulciuc wslulciuc enabled auto-merge (squash) November 10, 2022 17:46
@wslulciuc wslulciuc disabled auto-merge November 10, 2022 17:46
@wslulciuc wslulciuc disabled auto-merge November 10, 2022 17:46
@wslulciuc wslulciuc merged commit 448dd91 into main Nov 10, 2022
@wslulciuc wslulciuc deleted the code-quality-doc branch November 10, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants